[PATCH SET] Refactoring of auth_ntlmssp

[simo]

On Sun, 2010-07-18 at 08:23 +1000, Andrew Bartlett wrote:
> On Sat, 2010-07-17 at 15:08 -0400, simo wrote:
> > Hello,
> > I have refactored a bit the way we deal with auth_ntlmssp in this tree:
> > http://git.samba.org/?p=idra/samba.git;a=shortlog;h=refs/heads/ntlmssp
> > 
> > The aim was to be able to always use ntlmssp_state instead of a mix of
> > ntlmss_state/auth_ntlmssp_state so that I can proceed with cleaning up
> > cli_pipe.c/srv_pipe.c and make more code common between them. The main
> > obstacle was the use of auth_ntlmssp_state vs ntlmssp_state.
> > 
> > If there are no objections I'd like to push the top most 15 patches to
> > master. It passes make test and make selftest.
> 
> Thanks for looking into this.  I'll look at it early next week.  
> 
> However, my main concern (and perhaps it isn't warranted, which is why
> I'll look at it properly next week) is that currently I can replace
> auth_ntlmssp_state with a GENSEC wrapper in s3compat.  Without the
> intermediate structure of a different name, it may become much more
> difficult to make this change.   (We had a similar problem when trying
> to merge the NTLMSSP code late last year, and had to re-introduce a
> wrapper structure in GENSEC). 

Sorry,
but I need this change to go on with my other work in the msrpc branch.

So unless the code is factually wrong I would still go on with this
change. Once I will be done with the changes I am making it will be a
simple matter replacing the rpc wrappers, as for the smbd code there
very few places where ntlmssp_state is used I am sure it can be dealt
with.

Note that auth_ntlmssp_state as a structure still exist, it is simply
concealed in ntlmssp_state.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>