[PATCH SET] Refactoring of auth_ntlmssp

Andrew Bartlett abartlet at samba.org
Sat Jul 17 16:23:37 MDT 2010

On Sat, 2010-07-17 at 15:08 -0400, simo wrote:
> Hello,
> I have refactored a bit the way we deal with auth_ntlmssp in this tree:
> http://git.samba.org/?p=idra/samba.git;a=shortlog;h=refs/heads/ntlmssp
> The aim was to be able to always use ntlmssp_state instead of a mix of
> ntlmss_state/auth_ntlmssp_state so that I can proceed with cleaning up
> cli_pipe.c/srv_pipe.c and make more code common between them. The main
> obstacle was the use of auth_ntlmssp_state vs ntlmssp_state.
> If there are no objections I'd like to push the top most 15 patches to
> master. It passes make test and make selftest.

Thanks for looking into this.  I'll look at it early next week.  

However, my main concern (and perhaps it isn't warranted, which is why
I'll look at it properly next week) is that currently I can replace
auth_ntlmssp_state with a GENSEC wrapper in s3compat.  Without the
intermediate structure of a different name, it may become much more
difficult to make this change.   (We had a similar problem when trying
to merge the NTLMSSP code late last year, and had to re-introduce a
wrapper structure in GENSEC). 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100718/11d82d6a/attachment.pgp>

More information about the samba-technical mailing list