LDB hidden memory leaks
Stefan (metze) Metzmacher
metze at samba.org
Sat Jul 10 02:16:31 MDT 2010
> I think I am done with ldb refactoring for now
> (at least, we should get a lot less leaked ldb_msg objects during
> I will appreciate if you find some spare time to review my branch at:
Regarding the reformating:
I'd like to push this patch
which explains good and bad comment example.
It would be nice if you could push this for me, if nobody complains.
The reformat in the explained style.
The way you added this:
+#define _DEPRECATED_ __attribute__ ((deprecated))
is not portable, not every compiler supports this.
The correct definition already comes from replace.h.
So ldb.h only needs this:
I'm wondering if ldb_msg_canonicalize[_ex] should take care of the
only elements of the same type should be combined. (But that can be an
I haven't look at the other changes in detail...,
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 262 bytes
Desc: OpenPGP digital signature
More information about the samba-technical