Reverted auth patches

Andrew Bartlett abartlet at samba.org
Thu Jul 8 22:33:18 MDT 2010


On Sun, 2010-07-04 at 13:05 -0400, simo wrote:
> On Sun, 2010-07-04 at 00:24 +0200, Jelmer Vernooij wrote:
> > A while ago these three patches to source3/auth were reverted because
> > they hadn't been reviewed. 
> > 
> > I think these patches are reasonable so I'm happy to sign off on them.
> > I'm keen to see them land as they bring us one step closer towards
> > being
> > able to use the Samba 3 Winbind in Samba 4.
> > 
> > Since there was so much heated discussion around these patches I
> > wanted
> > to run it by the mailing list first. If you object to these patches,
> > please speak up. 
> 
> In previous patches I already found errors (through valgrind).
> 
> Please before pushing anything make sure the code is actually tested in
> a pure s3 setup, not just in an s3-compat one.
> 
> Also you should really get an ack from Volker as he did object about
> them.

Volker:  Do you have any technical objections to the patches?

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-auth-Change-auth_ntlmssp_server_info-API-to-retur.patch
Type: text/x-patch
Size: 5228 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100709/8c6790f0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Fix-segfault-if-register_existing_vuid-fails.patch
Type: text/x-patch
Size: 1965 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100709/8c6790f0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Give-the-kerberos-session-key-a-parent.patch
Type: text/x-patch
Size: 908 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100709/8c6790f0/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100709/8c6790f0/attachment.pgp>


More information about the samba-technical mailing list