90b1a1d - s3: Add SMB2 performance counters

Ira Cooper samba at ira.wakeful.net
Thu Jul 8 06:39:34 MDT 2010


I don't object to a revert or an expansion of the macros.  I'd like a
little time to see if I can throw something cleaner together.

Topic changed per Andrew's comments.

-Ira

On Thu, Jul 8, 2010 at 7:18 AM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> On Wed, Jul 07, 2010 at 08:09:45PM -0500, Jeremy Allison wrote:
>> The branch, master has been updated
>>        via  90b1a1d... s3: Add SMB2 performance counters.
>>       from  609b865... s4-dsdb/util: Reorder DSDB_FLAG_* checks
>>
>> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
>>
>>
>> - Log -----------------------------------------------------------------
>> commit 90b1a1d29623c6c2abc86e2571b535a7832dd376
>> Author: Ira Cooper <samba at ira.wakeful.net>
>> Date:   Thu Jul 1 17:51:41 2010 -0400
>>
>>     s3: Add SMB2 performance counters.
>>
>>     A performance counter was added for every base type of SMB2 op.
>
> Can we get rid of these very, very strange
> PROFILE_AND_RETURN macros? Function calls (that's what
> macro calls look like) doing magic returns and allocating
> variables on the stack are bound to cause trouble very, very
> quickly.
>
> Thanks,
>
> Volker
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkw1s/IACgkQbZMKAi3WUkkEpACgjU9NRjUW1Ccf1wnFUzD8lD5b
> 7p0AniXnlwxKtW61VaIy6c85VomUs+zg
> =Eo1R
> -----END PGP SIGNATURE-----
>
>


More information about the samba-technical mailing list