[SCM] Samba Shared Repository - branch master updated
jra at samba.org
Tue Jul 6 19:26:36 MDT 2010
On Mon, Jul 05, 2010 at 04:03:41PM +0200, Volker Lendecke wrote:
> On Mon, Jul 05, 2010 at 09:50:38AM -0400, simo wrote:
> > However assuming we do not keep DB formats stable, what will happen if
> > someone tries to join a new samba version to a CTDB cluster ?
> > Will it warn something in the logs and shutdown itself ? Or will it try
> > to write database entries and compromise the functionality of all other
> > nodes ? Or is there some other mechanism that will prevent harm in any
> > way ?
> Nothing right now will warn you.
Adding that check would seem to be the simplest fix :-).
BTW. Simo, I did ask before adding that SMB2 code. I also
thought about it a *lot* before adding it. The alternative
(keeping an in-memory mapping table between 16bit and 64-bit
mids) was worse...
IMHO This kind of change is perfectly ok if the developer
explains the reasons before doing it and gets a buy-off
from others who have an interest in maintaining that code
(and I understand Volker's reasons for doing this fix, and
it makes sense to me).
More information about the samba-technical