Reverted auth patches

simo idra at
Sun Jul 4 11:05:55 MDT 2010

On Sun, 2010-07-04 at 00:24 +0200, Jelmer Vernooij wrote:
> A while ago these three patches to source3/auth were reverted because
> they hadn't been reviewed. 
> I think these patches are reasonable so I'm happy to sign off on them.
> I'm keen to see them land as they bring us one step closer towards
> being
> able to use the Samba 3 Winbind in Samba 4.
> Since there was so much heated discussion around these patches I
> wanted
> to run it by the mailing list first. If you object to these patches,
> please speak up. 

In previous patches I already found errors (through valgrind).

Please before pushing anything make sure the code is actually tested in
a pure s3 setup, not just in an s3-compat one.

Also you should really get an ack from Volker as he did object about


Simo Sorce
Samba Team GPL Compliance Officer <simo at>
Principal Software Engineer at Red Hat, Inc. <simo at>

More information about the samba-technical mailing list