[SCM] Samba Shared Repository - branch master updated

Stefan (metze) Metzmacher metze at samba.org
Sun Jul 4 10:48:42 MDT 2010


Hi Volker,

Am 04.07.2010 14:59, schrieb Volker Lendecke:
> The branch, master has been updated
>        via  ba57d23... s3: ALWAYS run make test before checkin ....
>       from  34558ae... s3: Slight reshaping of server_exists_parse
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit ba57d23c1ce5ef3b6c4b2e5e100a0457b8abdcbf
> Author: Volker Lendecke <vl at samba.org>
> Date:   Sun Jul 4 14:59:23 2010 +0200
> 
>     s3: ALWAYS run make test before checkin ....
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source3/lib/serverid.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> Changeset truncated at 500 lines:
> 
> diff --git a/source3/lib/serverid.c b/source3/lib/serverid.c
> index e9c7296..dc4834b 100644
> --- a/source3/lib/serverid.c
> +++ b/source3/lib/serverid.c
> @@ -187,8 +187,8 @@ static int server_exists_parse(TDB_DATA key, TDB_DATA data, void *priv)
>  	 * Use memcmp, not direct compare. data.dptr might not be
>  	 * aligned.
>  	 */
> -	state->exists =
> -		(memcmp(&unique_id, data.dptr, sizeof(unique_id)) == 0);
> +	state->exists = (memcmp(&state->id->unique_id, data.dptr,
> +				sizeof(unique_id)) == 0);
>  	return 0;

isn't the "unique_id" variable unused, if we use
sizeof(state->id->unique_id)?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100704/18e98c3f/attachment.pgp>


More information about the samba-technical mailing list