s4:acl LDB module - fix counter type

Matthias Dieter Wallnöfer mdw at samba.org
Fri Jul 2 05:24:27 MDT 2010


"ldb.h" specifies "unsigned int" for all LDB object counter variables 
(please have a look).
While a theoretically limit I would like to have it used for all such 
counting purposes to have no unneeded implicit variable conversions.
For "dsdb" (replication) objects and other RPC communication the counter 
variables have to be from type "uint32_t".
I see no problem if torture tests break with that convention but 
server-specific code should follow it.


Nadezhda Ivanova wrote:
> Hi Matthias,
> I wasn't aware that we had a coding style requirement to have unsigned 
> counters. I don't remember reading this - or seeing it as general 
> practice in the code... Is it in the coding style and I missed it? For 
> some reason I think that if it were Metze would have caught it :).
> Regards,
> Nadya

More information about the samba-technical mailing list