s3:auth Fix switch statement referencing a uninitialized variable

simo idra at samba.org
Thu Jul 1 21:18:41 MDT 2010


On Fri, 2010-07-02 at 10:19 +1000, Andrew Bartlett wrote:
> On Thu, 2010-07-01 at 17:34 -0500, Simo Sorce wrote:
> > The branch, master has been updated
> >        via  3721161... s3:auth Fix switch statement referencing a uninitialized variable
> >       from  d1538ad... s3-nss_info: only include nss_info.h where needed.
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 3721161d90c835604f38d2f178fbcd8c5f708077
> > Author: Simo Sorce <idra at samba.org>
> > Date:   Thu Jul 1 17:47:46 2010 -0400
> > 
> >     s3:auth Fix switch statement referencing a uninitialized variable
> >     
> >     Looking at the original commit (9a747d500fad699038ecf75615c680a9fd9e4cc7)
> >     this seem the right solution.
> >     
> >     Andrew please check.
> 
> Yes, that looks correct to me.  (And was missed by the test-suite
> because at the moment, the 'want sign' calls are stubs in Samba3, but
> implemented in s3compat). 

Valgrind found it immediately as the check is always performed.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list