Bugfix for tdb transactions

Volker Lendecke Volker.Lendecke at SerNet.DE
Sun Jan 31 11:11:13 MST 2010

On Sun, Jan 31, 2010 at 08:10:20PM +1100, tridge at samba.org wrote:
> I think if you leave the tdb->transaction->prepared boolean alone, and
> instead add a new bool to the transaction structure that gets set when
> the GLOBAL_LOCK is taken then the patch will be good.

Thanks for the review! New patch attached. This time I did
run tdbtorture, seems to survive it fine. I'll run the
original test that found the bug tomorrow (need to VPN into
the customer network).

> Thanks for finding the bug! I can imagine that this was not an easy
> one to find :-)

The main problem why it took so long was that I trusted the
tdb code... I looked everywhere but in lib/tdb, but once I had
instrumented ctdb to not use mmap so that I could see the
actual db access, it was pretty obvious what was going on.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tdb-fix-an-early-release-of-the-global-lock-that-ca.patch
Type: text/x-diff
Size: 3345 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100131/2c3bfbda/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100131/2c3bfbda/attachment.pgp>

More information about the samba-technical mailing list