[PATCH] s4/ldap: Fix nested searches SEGFAULT bug

[Kamen Mazdrashki]

Hi Simo,

On Fri, Jan 29, 2010 at 15:13, simo <idra at samba.org> wrote:
>
> Kamen can you explain in what case a recursion can happen for the same
> request ?
> I need to understand what bug you are trying to fix here to say whether
> or not this patch is a good idea.
>

The commit before the fix-commit implements such a test to reveal this bug?
(But I guess you are not asking this right) :)

Anyways, here is how I hit this bug in first place.
I was implementing --show-binary for ms-prefixMap attribute value.
It happens that bot Samba4 and AD use the same attribute, but with
different format for data.
Thus in ldif_write() function for prefixMap, I decided to check if the
ldb_context is against Samba4
implementation or against Windows AD - I made a search for
"vendorName" in RootDSE.
At this point I got SEGFAULT - it turns out this SEGFAULT happens in
ldb_search_callback()
implemented by ldbsearch utlity. SEGFAULT happens because when we read
SEARCH_DONE tag
on the wire, we triger callback notification, which in turns
mistakenly sends LDAP_SEARCH_RESULT
value (which value we are alredy processing) again to the
ldb_search_callback() function.

It became a quite messy explanation, sorry for that...

-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/