SMBC_parse_path doesn't seem to handle special characters

[Eduardo Kienetz]

On Tue, Jan 26, 2010 at 7:22 AM, SATOH Fumiyasu <fumiyas at osstech.jp> wrote:

> At Mon, 25 Jan 2010 10:52:32 -0600,
> Eduardo Kienetz wrote:
> > > True. But then to cover that 100% we need a proper escaping
> > > mechanism, something like quoted-printable or base64-encoded
> > > utf8 (like LDAP does) that fits into the url scheme.
> > >
> >
> > Oh, you mean we should require the password to be base64 encoded? Doesn't
> > seem that good since it still might return / in it (unless we use
> modified
> > versions).
>
> I think we must require the username and the password to be
> URI-encoded (RFC 2396, RFC 2732), and libsmbclient must
> require the URI-encoded username/password to be URI-decoded.
>
> e.g.: smb://user:p%40ss%2Fword%5C%40m@serv@r/m@share/m@filename.txt
>


Ouch, would be good to know that a week ago :)

Anyway, I've reverted my patch here and am using urlencode. Probably that
needs clarification in the documentation/man page/whatever D:

Thanks,

Ed