SMBC_parse_path doesn't seem to handle special characters

[Eduardo Kienetz]

On Sun, Jan 24, 2010 at 5:16 AM, Volker Lendecke
<Volker.Lendecke at sernet.de>wrote:

> On Sun, Jan 24, 2010 at 12:32:25AM -0600, Eduardo Kienetz wrote:
> > Agreed, but the bottom line is that that's supported, because some
> developer
> > had [good?] reasons to do so, and it doesn't work right :)
>
> True. But then to cover that 100% we need a proper escaping
> mechanism, something like quoted-printable or base64-encoded
> utf8 (like LDAP does) that fits into the url scheme.
>
> The reason I'm a bit reluctant to put in your patch directly
> is the fact that I personally are always scared by
> string-parsing. This code is already very hard to
> understand for me.
>

Alright, the attached patch enables proper parsing of passwords with special
characters.
It requires that you escape @s contained in a password. That's all.

If the attachment gets scrubbed (again), you can get it from:
http://www.kienetz.com/0001-SMBC_parse_path-now-handles-special-characters-in-pa.patch

I had to create a next_token_internal_escaped_talloc, that would skip the
separators that are escaped.

My only concern is regarding portability of this code, since I don't really
have experience programming for multiple platforms.

Thank you in advance for any comments on this,

Eduardo Bacchi Kienetz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SMBC_parse_path-now-handles-special-characters-in-pa.patch
Type: application/octet-stream
Size: 5155 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100125/6f8f24b9/attachment.obj>