[Patchs]

[Stefan (metze) Metzmacher]

Hi Matthieu,

>From e3ba25c6737410df4f71060d63d4ad51613d3ea5 Mon Sep 17 00:00:00 2001
>From: Matthieu Patou <mat at matws.net>
>Date: Sat, 23 Jan 2010 01:43:24 +0300
>Subject: [PATCH] don't return a buffer if we were not able to decrypt
>it \!
>
>---
> epan/dissectors/packet-dcerpc-netlogon.c |    1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/epan/dissectors/packet-dcerpc-netlogon.c
>b/epan/dissectors/packet-dcerpc-netlogon.c
>index d01ceed..346b189 100644
>--- a/epan/dissectors/packet-dcerpc-netlogon.c
>+++ b/epan/dissectors/packet-dcerpc-netlogon.c
>@@ -7912,7 +7912,6 @@ dissect_packet_data(tvbuff_t *tvb ,tvbuff_t
>*auth_tvb _U_,
>   }
>   else {
>     debugprintf("Vars not found  %d
>(packet_data)\n",g_hash_table_size(netlogon_auths));
>-    return(buf);
>   }
>
>   return(buf);

You haven't tested this patch:-)
This change is a noop. If we do the same return statement 2 lines later.
Would return NULL be the correct thing?

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100123/fdd195ba/attachment.pgp>