s4-winbind: Migrated winbind connection to tsocket.

Andrew Bartlett abartlet at samba.org
Wed Jan 20 14:53:24 MST 2010


On Wed, 2010-01-20 at 15:48 -0600, Stefan Metzmacher wrote:
> The branch, master has been updated
>        via  fd6a792... s4-winbind: Migrated winbind connection to tsocket.
>       from  3471d36... selftest-s4: set the posix:eadb at the global level
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit fd6a79228347ec032294a1f462dda56095fc1d8b
> Author: Andreas Schneider <asn at redhat.com>
> Date:   Sun Jan 17 10:21:21 2010 +0100
> 
>     s4-winbind: Migrated winbind connection to tsocket.
>     
>     Signed-off-by: Stefan Metzmacher <metze at samba.org>
> 
> -----------------------------------------------------------------------
> 
> Summary of changes:
>  source4/winbind/wb_samba3_protocol.c |  101 +++++++++++++---------
>  source4/winbind/wb_server.c          |  157 ++++++++++++++++++++++++++--------
>  source4/winbind/wb_server.h          |   11 ++-
>  3 files changed, 191 insertions(+), 78 deletions(-)

Looking over this changeset, and the previous ones for ntp_signd and the
KDC, it seems that the change to tsocket is still introducing a fair bit
of boilerplate code.  Would it be possible to try and put more of this
(I'm thinking the loop in particlar) in a helper function?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100121/b56fee4d/attachment.pgp>


More information about the samba-technical mailing list