Can someone please make this change to configure.in in source3 so that Samba 3.4.4 etc can cross compile.
Lars Müller
lars at samba.org
Mon Jan 18 07:53:22 MST 2010
On Thu, Jan 14, 2010 at 02:43:49PM -0800, Richard Sharpe wrote:
> diff -u samba-3.4.4/source3/configure.in
> CompileArea/samba-3.4.4/source3/configure.in
> --- samba-3.4.4/source3/configure.in 2010-01-04 05:01:25.000000000 -0800
> +++ CompileArea/samba-3.4.4/source3/configure.in 2010-01-14
> 14:54:52.000000000 -0800
> @@ -1243,7 +1243,9 @@
> #endif
> exit(0);
> }
> -], [linux_getgrouplist_ok=yes], [linux_getgrouplist_ok=no])
> +], [linux_getgrouplist_ok=yes],
> + [linux_getgrouplist_ok=no],
> + [linux_getgrouplist_ok=cross])
> if test x"$linux_getgrouplist_ok" = x"yes"; then
> AC_DEFINE(HAVE_GETGROUPLIST, 1, [Have good getgrouplist])
> fi
I modified your patch to fit into the slightly changed code of master
(samba_cv_linux_getgrouplist_ok instead of linux_getgrouplist_ok).
But then I found that linux_getgrouplist_ok=cross had been there in the
past already. It got removed with e5a95132 and I believe the removal
happened accidentl while moving into direction of 3.2.
@Jerry: could you please check if my assumption is right or if I've
missed the point?
@Richard: if my assumption is correct and we unintentionally lost the
code please file one bug for 3.4 and 3.5 as you need a review ack in
bugzilla to get the change merged. As I already had an eye on the stuff
feel free to ass me as reviewer.
Lars
-------------- next part --------------
A non-text attachment was scrubbed...
Name: source3_configure.in.diff
Type: text/x-patch
Size: 556 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100118/cf89194e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100118/cf89194e/attachment.pgp>
More information about the samba-technical
mailing list