[PATCH] Preliminary inline arrays support in wireshark.pm

Julien Kerihuel j.kerihuel at openchange.org
Mon Jan 18 07:06:48 MST 2010


Hi List,

Here is another patch I have applied on my local openchange dissector
trunk to enable support for inline arrays when generating the wireshark
dissector code. This is a PIDL patch only which may need to be turned
into wireshark code in the future if required.

The implementation is currently quite similar to the nodiscriminant one
(previously posted), which means that it may suffer from similar design
flaw. I'm posting the diff from openchange repository since offset are
likely to differ from samba master-git repository ones.

http://websvn.openchange.org/diff.php?repname=dissector&path=%2Fpidl%
2Flib%2FParse%2FPidl%2FWireshark%2FNDR.pm&rev=20


The overall idea is to:
1. look for arrays element with IS_INLINE property within the
CheckElement routine
2. If found, tag the "inline size" element with some additional
properties
3. Generate additional code where needed to retrieve the inline size and
pass it to the function dissecting the inline array.

Cheers,
Julien.

Julien Kerihuel
j.kerihuel at openchange.org
OpenChange Project Manager

GPG Fingerprint: 0B55 783D A781 6329 108A  B609 7EF6 FE11 A35F 1F79


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100118/64d81208/attachment.pgp>


More information about the samba-technical mailing list