ntacl and upgradeprovision patches

[Matthieu Patou]

Hello all,

>> [596/608 in 1819s, 1 errors] samba4.ldap_schema.python (dc)
>> [597/608 in 2034s, 1 errors] samba4.ldap.possibleInferiors.python (dc)
>> [598/608 in 2036s, 1 errors] samba4.ldap.secdesc.python (dc)
>> [599/608 in 2270s, 1 errors] samba4.ldap.acl.python (dc)
>> [600/608 in 2300s, 1 errors] samba4.xattr.python
>> UNEXPECTED(error):
>> samba4.xattr.python.samba.tests.xattr.XattrTests.test_set_and_get_native
>> REASON: Traceback (most recent call last):
>>     File "bin/python/samba/tests/xattr.py", line 60, in
>> test_set_and_get_native
>>       samba.xattr_native.wrap_setxattr(tempf,"user.unittests",reftxt)
>> TypeError: Operation not supported
>> UNEXPECTED(error):
>> samba4.xattr.python.samba.tests.xattr.XattrTests.test_set_xattr_native
>> REASON: Traceback (most recent call last):
>>     File "bin/python/samba/tests/xattr.py", line 44, in test_set_xattr_native
>>
>> samba.xattr_native.wrap_setxattr(tempf,"user.unittests",ndr_pack(ntacl))
>> TypeError: Operation not supported
>> command: /usr/bin/python2.5 ./selftest/../scripting/bin/subunitrun
>> samba.tests.xattr
>> expanded command: /usr/bin/python2.5
>> ./selftest/../scripting/bin/subunitrun samba.tests.xattr
>> ERROR: Testsuite[samba4.xattr.python]
>> REASON: Subunit/Filer Reason
>>    errors[2]
>
> I get this same error on Fedora 12 i686
In a way I'm surprised, in another it shows that the tests was not 
complete enough.
So surprised because this test use user xattr to test that the python 
binding is able to manipulate xattr, and unless that you have a 
filesystem with -o nouser_xattr as an option then it should work (at 
least it's like that on my ubuntu and it seems to be also the same on my 
fedora 12 i386 with a ext4 fs).
In any case it shows that the tests should check if the FS support xattr 
and if not skip it.
I changed the code so that the python binding returns a different 
exception if we face a ENOTSUP error while calling wrap_(g|s)etxattr.

No it seems ok on my ubuntu with a filesystem mounted nouser_xattr 
(while setfattr -n "user.foo" -v "bar" foobar fails).


>
> Andrew Bartlett

Matthieu.