[SCM] Samba Shared Repository - branch master updated
jra at samba.org
Fri Jan 15 17:45:32 MST 2010
On Thu, Jan 14, 2010 at 12:50:26PM -0600, Günther Deschner wrote:
> +/* note the strdup for string options on smbc_set calls. I think libsmbclient is
> + * really doing something wrong here: in smbc_free_context libsmbclient just
> + * calls free() on the string options so it assumes the callers have malloced
> + * them before setting them via smbc_set calls. */
God you're right - that's *REALLY* horrible. libsmbclient
should have been deep copying the strings from the start,
not just stealing the pointers.
Can we track down the gvfs backend code that calls this
and see how hard it would be to fix this mess ?
More information about the samba-technical