[PATCH] s4-drs: Reads uSNUrgent and sets Urgent Replication Bit for DS_ReplicaSync when necessary

[Fernando J V da Silva]

Hi Tridge!


> Will you do a patch to add that bit for urgent notifies? The changes
> should be quite simple:
>
>  - add an urgent bool to struct dreplsrv_op_notify_state
>  - add a urgentUSN argument to dreplsrv_schedule_notify_sync()
>  - fill in the bit on the wire

I've attached two patches for that task and they are also available at
repo.or.cz. A few comments which should be pointed out:
    - I didn't see how to handle the urgent bool at the struct
dreplsrv_op_notify_state ... I've put it on struct
dreplsrv_notify_operation, but if you want I may change it!
    - I reviewed the documentation at [MS-ADTS] 3.1.1.5.1.5
Replication Notification (at
http://msdn.microsoft.com/en-us/library/dd240019(PROT.13).aspx) and it
also says the following:

          Let N be the NC replica where the originating or replicated
update has occurred on the server.

          For each i in [0 .. (N!repsTo).length-1] do the following:

                               ... (several lines of documentation
here ...)

                               - Let pmsgIn be a reference to a
structure of type DRS_MSG_REPSYNC.

                               ... (several lines of documentation here ...)

                               - If (pmsgIn->V1.ulOptions &
DRS_SYNC_URGENT = 0), then wait for an implementation-specific time T.
If i = 0 the default time T is 15 seconds; if i > 0 the default time T
is 3 seconds.

                               ... (several lines of documentation here ...)

    It seems that it should wait 15 seconds before send DS_ReplicaSync
message to the first replica and 3 seconds before send for the others,
on urgent replication ... (Does it seem to be right? (If so, I wrote
that another separate patch, but it is at wip-drs_urgent_wait branch
on my repository)).


Best Regards,

-- 
Fernando J V da Silva
M Sc Computer Science Student
Institute of Computing, State University of Campinas
+55 15 8801-2165
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-drs-Reads-uSNUrgent-and-sets-Urgent-Replication.patch
Type: text/x-patch
Size: 3931 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100115/a66df7f5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-drs-Waits-for-a-implementation-specific-time-to.patch
Type: text/x-patch
Size: 4717 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100115/a66df7f5/attachment-0001.bin>