ntacl and upgradeprovision patches

tridge at samba.org tridge at samba.org
Thu Jan 14 20:29:43 MST 2010

Hi Matthieu,

 > So the merged branch available here: 
 > http://repo.or.cz/w/Samba/ekacnet.git/shortlog/refs/heads/merge-acl-prov
 > Contains series of patch that build and pass tests on my computer 
 > (andrew: I rebased the whole stuff to add the patch that fixed the build 
 > error that you had).

It fails to compile for me, with this error:

Compiling scripting/python/pyxattr_native.c
scripting/python/pyxattr_native.c: In function 'py_wrap_getxattr':
scripting/python/pyxattr_native.c:72: error: implicit declaration of function 'getxattr'
scripting/python/pyxattr_native.c:77: warning: pointer targets in passing argument 1 of 'PyString_FromStringAndSize' differ in signedness

Fixing the compilation is easy, it's just this change:

--- a/source4/scripting/python/pyxattr_native.c
+++ b/source4/scripting/python/pyxattr_native.c
@@ -69,7 +69,7 @@ static PyObject *py_wrap_getxattr(PyObject *self, PyObject *args)
        /* check length ... */
        buf = talloc_zero_array(mem_ctx, uint8_t, len);
-       len = getxattr(filename,attribute,buf,len);
+       len = wrap_getxattr(filename,attribute,buf,len);
        if( len < 0 ) {
                PyErr_SetString(PyExc_TypeError, strerror(errno));
                return NULL;

but then make test fails with this in provision:

Traceback (most recent call last):
  File "./setup/provision", line 243, in <module>
  File "bin/python/samba/provision.py", line 1334, in provision
  File "bin/python/samba/provision.py", line 1080, in setsysvolacl
  File "bin/python/samba/ntacls.py", line 77, in setntacl
    attribute = samba.xattr_native.wrap_setxattr(file,xattr.XATTR_NTACL_NAME,ndr_pack(ntacl))
TypeError: Operation not permitted

I haven't looked into it any further, sorry.

Cheers, Tridge

More information about the samba-technical mailing list