[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon Jan 11 11:17:22 MST 2010

On Thu, Jan 07, 2010 at 07:57:39AM -0600, Volker Lendecke wrote:
> The branch, master has been updated
>        via  801edec... s3: Remove some code that has become unnecessary
>       from  c1ca000... s3-docs: fix eventlogadm manpage typo.
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> - Log -----------------------------------------------------------------
> commit 801edeccc6f529647eaed0dd23728a257cf9479f
> Author: Volker Lendecke <vl at samba.org>
> Date:   Thu Jan 7 14:50:43 2010 +0100
>     s3: Remove some code that has become unnecessary
>     The code I just removed was checked in with e5466fffc286a99f as a bug fix for
>     https://bugzilla.samba.org/show_bug.cgi?id=3319. With the changes to
>     is_visible_file made with 9e8b8f8c16612 these lines have become unnecessary,
>     even with "hide unreadable = yes" dead msdfs symlinks show. This is because we
>     can not stat(2) them and default to showing them.
>     Why this change? I have a user who wants to use "hide unreadable" on msdfs
>     links. Because you can't edit acls on symlinks themselves, the user created the
>     targets as bogus, empty files that just exist as acl placeholders. With the
>     code in place that this patch removes, we never allow this to work.
>     Jeremy, please check! :-)

Finally got time to review this. Yes, looks good and removes
unneccessary code !



More information about the samba-technical mailing list