[Patches] proposal in order to allow to be able to have pam_winbind libs in s4

Matthieu Patou mat+Informatique.Samba at matws.net
Tue Feb 23 14:24:10 MST 2010


On 20/02/2010 11:35, Stefan (metze) Metzmacher wrote:
> Matthieu Patou schrieb:
>> Hello,
>>
>> Please find attached a couple of patch that allow to have the
>> pam_winbind.so it compiles on s3 and s4 but I didn't run make tests on
>> them (yet).
>
> Please move iniparser to lib/iniparser to match other imported libs
> like zlib and popt.
>
> I think the usage of dyn_LOCALEDIR in pam_winbind.c is wrong,
> it will never be able to change the value to something other than
> LOCALDIR. I think we should use LOCALDIR directly.
>
Is everybody Ok with this modification  ? it should impact s3 as well if 
I'm not misunderstanding ?
> Then we don't have to move the localdir.[ch] files.
> (If you want them to move anyway they should both move to lib/util/)
>
> metze
>
>

Matthieu.


More information about the samba-technical mailing list