[PATCHES] Rationalizing and unifing Schannel

[simo]

On Tue, 2010-02-23 at 09:26 -0500, simo wrote:
> On Tue, 2010-02-23 at 09:39 +0100, Stefan (metze) Metzmacher wrote:
> > simo schrieb:
> > > I have been working on a patchset to enhance the schannel interface and
> > > also to make it possible to share this code between S3 and S4 again.
> > > 
> > > The first 6 patches shouldn't be controversial.
> > > The last 2 patches remove the use of ldb and goes back to use a tdb for
> > > samba4, the comment on patch 7 explains the rationale.
> > > 
> > > Unless there are objections I will push this patches during the week.
> > 
> > Hmm, I think we should think about the tdb_wrap_open() usage
> > a bit more. It uses talloc_reference() and the caller uses
> > talloc_free(). I think we should not explicit free it
> > we need a talloc parent that we free, as source3/lib/dbwrap_tdb.c
> > does.
> 
> Ok attached a new patch 0006 that uses a tmp context so tdb_sc is not
> directly freed.

Given there seemed there were no other substantial objections I went
ahead and pushed.

Thanks to metze for the review.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>