[PATCHES] Rationalizing and unifing Schannel
idra at samba.org
Tue Feb 23 07:08:56 MST 2010
On Tue, 2010-02-23 at 15:03 +0100, Volker Lendecke wrote:
> On Tue, Feb 23, 2010 at 08:59:12AM -0500, simo wrote:
> > > > > Hmm, I think we should think about the tdb_wrap_open() usage
> > > > > a bit more. It uses talloc_reference() and the caller uses
> > > > > talloc_free(). I think we should not explicit free it
> > > > > we need a talloc parent that we free, as source3/lib/dbwrap_tdb.c
> > > > > does.
> > > >
> > > > What about creating a tmpctx in the caller, and then freeing only that ?
> > >
> > > .... or rewriting tdb_wrap_open to not use talloc_reference? :-)
> > Too much for this patch set imo.
> Agreed, but that needs to be done at some point IMHO. I had
> given it a try a couple of months ago, but got distraced.
I'll let you try again :-)
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical