[PATCHES] Rationalizing and unifing Schannel
Volker Lendecke
Volker.Lendecke at SerNet.DE
Tue Feb 23 07:03:17 MST 2010
On Tue, Feb 23, 2010 at 08:59:12AM -0500, simo wrote:
> > > > Hmm, I think we should think about the tdb_wrap_open() usage
> > > > a bit more. It uses talloc_reference() and the caller uses
> > > > talloc_free(). I think we should not explicit free it
> > > > we need a talloc parent that we free, as source3/lib/dbwrap_tdb.c
> > > > does.
> > >
> > > What about creating a tmpctx in the caller, and then freeing only that ?
> >
> > .... or rewriting tdb_wrap_open to not use talloc_reference? :-)
>
> Too much for this patch set imo.
Agreed, but that needs to be done at some point IMHO. I had
given it a try a couple of months ago, but got distraced.
Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100223/aca43b2f/attachment.pgp>
More information about the samba-technical
mailing list