tsocket/bsd: fix bug #7115 FreeBSD includes the UDP header in FIONREAD
Stefan (metze) Metzmacher
metze at samba.org
Thu Feb 18 01:34:01 MST 2010
Hi Jeremy,
> - Log -----------------------------------------------------------------
> commit 936828de71023d90aaec6c1dba84052246bbad11
> Author: Jeremy Allison <jra at samba.org>
> Date: Wed Feb 17 09:24:34 2010 -0800
>
> Fix commit d07cd37b993d3c9beded20323174633b806196b5
>
> Which was:
>
> tsocket/bsd: fix bug #7115 FreeBSD includes the UDP header in FIONREAD
>
> Metze, this has to have been wrong - you are throwing away the talloc_realloc
> pointer returned. Also no error checking. Please review.
>
> Thank goodness for gcc warnings :-).
talloc_realloc would only shrink the size and can't fail, but it's good
to remove the warnings (you were faster with your commit because I had
no internet link...)
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100218/ffaad9c4/attachment.pgp>
More information about the samba-technical
mailing list