Remove talloc from libwbclient

Matthieu Patou mat+Informatique.Samba at matws.net
Mon Feb 8 00:50:18 MST 2010


Hi,
Instead of highjacking another thread can you simply start a new one so 
that we can follow talk on it simply ?

Matthieu.
On 08/02/2010 09:25, Rohit Rajan wrote:
> Hello Everyone,
>
> I'm building a environment with 2 samba4 domain controller with 2 DNS 
> servers, i started working and thought of upgrading the existing samb4 
> install which is
>
> Samba 4.0.0alpha11-GIT-802e932 on CentOS release 5.4 (Final), as per 
> the instructions in "upgrading-samba4.txt" i get errors as follows
>
>  #./scripting/bin/upgradeprovision
> Traceback (most recent call last):
>   File "./scripting/bin/upgradeprovision", line 49, in ?
>     from samba.misc import messageEltFlagToString
> ImportError: No module named misc
>
> Please let me know if anything else is required to do the upgrade
>
>
>
>
>
> On 2/8/2010 11:10 AM, Jeremy Allison wrote:
>> On Sun, Feb 07, 2010 at 12:48:46PM +0100, Volker Lendecke wrote:
>>> Looking at the existing users of talloc_init() and
>>> talloc_xx(NULL) I would say that almost all should replaced
>>> by something like talloc_tos() (which itself needs to use
>>> thread-local storage eventually)
>> talloc_tos() is already thread safe if compiled that
>> way (all the code is in place there).
>>
>>> or talloc_new(), they are
>>> just temporary contexts. The valid uses of a NULL context
>>> are rare enough that it might be possible to mutex that
>>> properly without noticable performance impact.
>> +1 !Yes - this is exactly what I want to do.
>>
>>> Libwbclient could then go and continue using talloc as it
>>> does right now.
>> Hmmm. Can't comment on the libwbclient bit (as I
>> haven't looked at that code for a while), but the
>> above is exactly the plan I've been wanting for a
>> while.
>>
>> Jeremy.
>
>



More information about the samba-technical mailing list