Remove talloc from libwbclient

Jeremy Allison jra at samba.org
Sun Feb 7 22:40:46 MST 2010


On Sun, Feb 07, 2010 at 12:48:46PM +0100, Volker Lendecke wrote:
> 
> Looking at the existing users of talloc_init() and
> talloc_xx(NULL) I would say that almost all should replaced
> by something like talloc_tos() (which itself needs to use
> thread-local storage eventually)

talloc_tos() is already thread safe if compiled that
way (all the code is in place there).

> or talloc_new(), they are
> just temporary contexts. The valid uses of a NULL context
> are rare enough that it might be possible to mutex that
> properly without noticable performance impact.

+1 !Yes - this is exactly what I want to do.

> Libwbclient could then go and continue using talloc as it
> does right now.

Hmmm. Can't comment on the libwbclient bit (as I
haven't looked at that code for a while), but the
above is exactly the plan I've been wanting for a
while.

Jeremy.


More information about the samba-technical mailing list