Review of brl scaling fix patches.
jra at samba.org
Sat Feb 6 18:41:07 MST 2010
On Sat, Feb 06, 2010 at 02:35:04PM +0100, Volker Lendecke wrote:
> On Sat, Feb 06, 2010 at 05:06:21PM +1100, tridge at samba.org wrote:
> > Hi Jeremy,
> > > Do these really need to be "static int"'s ?
> > I had forgotten that you were trying to reduce static vars in s3. I
> > only used one as lp_parm_int() uses get_parametrics() which is O(N) in
> > the number of non-fixed parameters. That means we pay a bit extra to
> > get the param when a child dies. I doubt it would be measurable
> > though, so it's fine just to init each time of course.
> Why not make it a real parameter?
It has more the feel of a "tweak" parameter than a real one,
but we've done real parameters for less in the past :-).
I don't feel strongly about it either way, so feel free to
turn it into a real one (just so long as it's not a static :-).
More information about the samba-technical