Remove talloc from libwbclient
Gerald Carter
jerry at samba.org
Sat Feb 6 10:00:59 MST 2010
Volker Lendecke wrote:
> Hi!
>
> In order to make libwbclient thread-safe, I would like to
> remove the use of talloc inside. I have also seen problems
> when the symbols get overwritten by talloc.so, so including
> a full talloc version from my point of view is a bad idea.
>
> We have to modify memory handling, in particular
> wbcFreeMemory though:
>
> 1. Add destructors preceding the memory blob returned
>
> 2. Change all of libwbclient to only ever allocate a single
> blob
>
> 3. Replace wbcFreeMemory by wbcFreeSomething per structure
Hey Volker,
I know you may be adverse to this but I already had to solve
this in Lsassd's implementation of the wbclient API.
The memory routines are very simple. You are welcome to them.
I went with solution (1).
http://git.likewiseopen.org/?p=likewise-open.git;a=blob;f=lsass/interop/wbclient/lsa_wbc_memory.c;h=e9e4e7717205688b978cafcf2f4d62a180f893e0;hb=HEAD
I know that you may decide not to due to the Likewise copyright.
But it's LGPLv2.1 so I'll leave it up to you.
cheers, jerry
--
=====================================================================
http://www.plainjoe.org/
"What man is a man who does not make the world better?" --Balian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/8e80130c/attachment.pgp>
More information about the samba-technical
mailing list