Review of brl scaling fix patches.

Volker Lendecke Volker.Lendecke at SerNet.DE
Sat Feb 6 06:35:04 MST 2010

On Sat, Feb 06, 2010 at 05:06:21PM +1100, tridge at wrote:
> Hi Jeremy,
>  > Do these really need to be "static int"'s ?
> I had forgotten that you were trying to reduce static vars in s3. I
> only used one as lp_parm_int() uses get_parametrics() which is O(N) in
> the number of non-fixed parameters. That means we pay a bit extra to
> get the param when a child dies. I doubt it would be measurable
> though, so it's fine just to init each time of course.

Why not make it a real parameter?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <>

More information about the samba-technical mailing list