Review of brl scaling fix patches.
jra at samba.org
Fri Feb 5 22:14:18 MST 2010
On Fri, Feb 05, 2010 at 08:04:37PM -0800, Jeremy Allison wrote:
> Do these really need to be "static int"'s ? I've been
> trying to reduce the number of statics we use in S3 smbd
> in order to eventually get to the safe use of background
> threads. I doubt these are performance critical, as it's
> just setting up an event time - and I don't think it matters
> if they were changed in smb.conf whilst smbd is running. So
> can these be changed to :
> int max_brl_timeout = lp_parm_int(-1, "brl", "recalctime", 5);
> and :
> int cleanup_time = lp_parm_int(-1, "smbd", "cleanuptime", 20);
> instead ?
Presuming you agree :-). Here is the patch sequence I'm planning
to apply to master. Let me know if you approve !
More information about the samba-technical