drsuapi.idl flags

Kamen Mazdrashki kamen.mazdrashki at postpath.com
Fri Feb 5 18:37:12 MST 2010


Hi Metze,

On Fri, Feb 5, 2010 at 13:05, Stefan (metze) Metzmacher <metze at samba.org> wrote:
> in 8 you still use
> 
> DRSUAPI_SUPPORTED_EXTENSION_40000000 and
> DRSUAPI_SUPPORTED_EXTENSION_80000000
>
Flags renamed.
 
> Also you should make almost every symbol in net_drs_bins.c static.
> And the casts to info28 and info48 are ugly and would may crash
> against a server that returns info24 or info28.
> 
> I think it would be better if net_drs_DsBind would construct
> a info48 and return that to the caller.
> 
Code is completely refactored (for good I hope).
I've misunderstand you for the 'cast thing' first time,
now it should be fine.

-- 
CU,
Kamen Mazdrashki
kamen.mazdrashki at postpath.com
http://repo.or.cz/w/Samba/kamenim.git
-------------------------------------
CISCO SYSTEMS BULGARIA EOOD
http://www.cisco.com/global/BG/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-idl-Naming-reserved-flags-for-DRSUAPI_SUPPORTED_.patch
Type: application/octet-stream
Size: 1022 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/0ee22ff1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-idl-regenerating-drsuapi.idl.patch
Type: application/octet-stream
Size: 2357 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/0ee22ff1/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-net_drs-net-drs-utility-initial-creation.patch
Type: application/octet-stream
Size: 12953 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/0ee22ff1/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-s4-net_drs-net-drs-bind-command-implementation.patch
Type: application/octet-stream
Size: 7297 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/0ee22ff1/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-s4-net_drs-net-drs-kcc-command-implementation.patch
Type: application/octet-stream
Size: 7019 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100206/0ee22ff1/attachment-0004.obj>


More information about the samba-technical mailing list