Patch to fix bad definition of smb_library
mat+Informatique.Samba at matws.net
Thu Feb 4 02:48:41 MST 2010
I saw on IRC that tridge is not ok with this patch as it conflicts with
s3 (ie. source3/configure.in).
But even without this patch we have a definition conflict between s4 and s3.
s3 definition for smb_library is:
dnl SMB_LIBRARY(name, version, default, reason)
dnl configure build and use of an (internal) shared library
whereas s4 definition is:
$1_CFLAGS = $6
$1_LDFLAGS = $7
n1_ENABLE = YES
$1_OBJ_FILES = $2
so for instance in s3 a call to smb_library will have the following format:
SMB_LIBRARY(addns, 0, no, [undefined API]) (ie. configure.in)
and in s4 it will be:
[LIBWINBIND-CLIENT]) (ie. nsswitch/config.m4)
In fact it looks like the SMB_LIBRARY is not too used in the common code
nor in s4 so we could fix the definition of smb_library to
so that it match both usage.
On 28/01/2010 00:38, Matthieu Patou wrote:
> Hello metze and jelmer,
> Please find attached a very simple patch to fix the smb_library macro
> that is broken.
More information about the samba-technical