Bugfix for tdb transactions

[Rusty Russell]

On Mon, 1 Feb 2010 06:01:12 pm Volker Lendecke wrote:
> On Mon, Feb 01, 2010 at 12:11:56PM +1100, tridge at samba.org wrote:
> > Hi Volker,
> > 
> > That looks better, but I'm still not sure we've completely fixed
> > this. Your patch will fix the case where a 2nd process opens the tdb
> > during the commit of the first process, but I don't think it fixes the
> > following case:
> > 
> >   - process 1 and 2 are both connected to the tdb
> >   - process 1 starts a transaction
> >   - process 1 starts a commit
> >   - admin uses kill -9 on process 1, while transaction is partially
> >     written (or segv or similar)
> >   - process 2 starts a transaction, and uses corrupt data from process 1
> 
> Before that is fixed, should we commit my patch to fix the
> problem that happens without the kill -9?

I prefer that.  I like it from a simplicity point of view, even though the
larger fix will revert it.

Cheers,
Rusty.