memory leak in gencache error path

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Dec 22 05:33:41 MST 2010

On Wed, Dec 22, 2010 at 12:51:45PM +0100, Stefan (metze) Metzmacher wrote:
> From reading the code it uses gencache_get().
> And gencache_get() calls gencache_get_data_blob().
> Both return false in case the entry has expired.
> gencache_get_data_blob() does an implicit gencache_set(keystr, "", 0)
> in that case before returning false.
> I looked through all callers of gencache_get_data_blob()
> and it seems that none expects blob to be filled if it returns false.
> Do you think it's ok to push my fix?

Haven't done the review myself, but it seems ok to me.


More information about the samba-technical mailing list