local memory contexts to avoid a discard_const_p()

Kamen Mazdrashki kamenim at samba.org
Mon Dec 20 04:11:44 MST 2010


On Mon, Dec 20, 2010 at 12:08, Andrew Bartlett <abartlet at samba.org> wrote:
> On Mon, 2010-12-20 at 11:43 +0200, Kamen Mazdrashki wrote:
>> >
>> It is this one:
>> http://git.samba.org/?p=samba.git;a=commitdiff;h=b974966cc2b4d0b5b0d83206070b5f7c5c6495d1
>>
>> I want to push this patch:
>> http://gitweb.samba.org/samba.git/?p=kamenim/samba.git;a=commitdiff;h=e7206cfd4f28f720b72065f2ccbba0fe465c7b7f
>> Is it ok for you all?
>
> That looks good.  I'm not sure that the schema can actually go away, but
> it is the pattern we use, because it's not always possible to know what
> the called functions will do.
>
I think you are right and we should stick to this pattern everywhere we
use ref-counted objects. We never know how the underlying implemetation
will change in the future.

> Andrew Bartlett
>
> --
> Andrew Bartlett                                http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Cisco Inc.
>
>


-- 
CU,
Kamen Mazdrashki
Samba Team                                            http://samba.org
http://gitweb.samba.org/?p=kamenim/samba.git;a=summary


More information about the samba-technical mailing list