patch review

[Jelmer Vernooij]

On Tue, 2010-12-14 at 14:32 +0300, Matthieu Patou wrote:
> Hi jelmer, stefan, tridge,
> 
> Can you review the impact of this patch:
> 
> 
> diff --git a/buildtools/wafsamba/wafsamba.py 
> b/buildtools/wafsamba/wafsamba.py
> index 3cb97c0..7758aff 100644
> --- a/buildtools/wafsamba/wafsamba.py
> +++ b/buildtools/wafsamba/wafsamba.py
> @@ -361,7 +361,7 @@ def SAMBA_MODULE(bld, modname, source,
>                    local_include=True,
>                    vars=None,
>                    enabled=True,
> -                 pyembed=True,
> +                 pyembed=False,
>                    ):
>       '''define a Samba module.'''
> 
> 
> On my system it didn't have any impact: samba4 is build
I think this is the right change to make and if nothing in particular
breaks then I think this is the right thing to do. Please push.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20101214/93457f9a/attachment.pgp>