s4-acl: Added a flag to mark an element as failing an access check.

[Nadezhda Ivanova]

You are right of course, I'll fix it. I guess I was distracted....

Regards,
Nadya

On Wed, Dec 8, 2010 at 1:08 PM, Andrew Bartlett <abartlet at samba.org> wrote:

> On Wed, 2010-12-08 at 12:01 +0100, Nadezhda Ivanova wrote:
> > The branch, master has been updated
> >        via  2079a6d s4-acl: Changed the mechanism of attribute removal to
> speed it up.
> >        via  fe98b9a s4-acl: Added a flag to mark an element as failing an
> access check.
> >       from  af3414f ndr: Another try to support the build on non-IPv6
> systems
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
>
> > commit fe98b9aaebd57e3461fa2ac59a2924a6ef6f09fa
> > Author: Nadezhda Ivanova <nivanova at samba.org>
> > Date:   Wed Dec 8 12:03:43 2010 +0200
> >
> >     s4-acl: Added a flag to mark an element as failing an access check.
> >
> > -----------------------------------------------------------------------
> >
> > diff --git a/source4/lib/ldb/include/ldb_module.h
> b/source4/lib/ldb/include/ldb_module.h
> > index 50c606b..a6a4d16 100644
> > --- a/source4/lib/ldb/include/ldb_module.h
> > +++ b/source4/lib/ldb/include/ldb_module.h
> > @@ -46,6 +46,9 @@ struct ldb_module;
> >  /* disable any single value checking on this attribute */
> >  #define LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK 0x20
> >
> > +/* attribute has failed access check and must not be exposed */
> > +#define LDB_FLAG_INTERNAL_INACCESSIBLE_ATTRIBUTE 0x30
> > +
>
> This isn't quite right.  Flags should be of individual bits - this patch
> has marked 2 bits 0x10 and 0x20.  Perhaps instead it should be 0x40 if
> it is unused?
>
> Andrew Bartlett
>
> --
> Andrew Bartlett                                http://samba.org/~abartlet/<http://samba.org/%7Eabartlet/>
> Authentication Developer, Samba Team           http://samba.org
> Samba Developer, Cisco Inc.
>