s4: Patch for "libnet/libnet_samsync_ldb.c"

Matthias Dieter Wallnöfer mdw at samba.org
Tue Dec 7 07:44:52 MST 2010

Hi Jelmer,

is "lib/ldb-samba" better than "dsdb/common/util.c"?

Regarding the other return values beside ERR_OPERATIONS_ERROR for out of 
memory it's not so easy. Caller functions differ in behaviour regarding 
NTSTATUS results - so I really thought it only to be used by msg_add* 
calls and not for "ldb_add", "ldb_modify" ecc.


Jelmer Vernooij wrote:
> Hi Matthias,
> I think we need a custom function that converts a ldb error to a
> NTSTATUS variable, if we don't have one already. Perhaps a
> ldb_error_to_ntstatus() function, living in lib/ldb-samba ?
> You're currently assuming that if a samdb_msg_add_string() call fails
> that this means a memory allocation error. We should support other
> values as well.
> Cheers,
> Jelmer

More information about the samba-technical mailing list