[PATCH] s4-ranged_result.c: Fix memory context for ranged attributes handling

Kamen Mazdrashki kamenim at samba.org
Wed Dec 1 02:08:12 MST 2010

On Tue, Nov 30, 2010 at 23:08, Andrew Bartlett <abartlet at samba.org> wrote:
> On Tue, 2010-11-30 at 19:04 +0200, Kamen Mazdrashki wrote:
> Aside from the extra semi-colon:
>> -       /* LDB_REPLY_ENTRY */
>> +       /* LDB_REPLY_ENTRY */;
oups :)
It seems my keyboard has it's own opinion how code should be written :)
Thanks for catching this!

> This looks good.  The original code clearly allocated a pointer that was
> potentially the second element in an array.
> Nice catch, both of you!
> (if autobuild cooperates, please push).
I wonder if we should wait a little bit so Zak to make a test first
to exploit this behavior (other way would be for him to write the test
on a branch without this fix)?


More information about the samba-technical mailing list