replace.h trivial copy/paste error?

Michael_E_Brown at Dell.com Michael_E_Brown at Dell.com
Thu Aug 19 16:15:24 MDT 2010


In tdb 1.2.1, libreplace/replace.h has:

/* Decimal notation.  */
#ifndef PRId8
# define PRId8      "d"
#endif
#ifndef PRId16
# define PRId16     "d"
#endif
#ifndef PRId32
# define PRId32     "d"
#endif
#ifndef PRId64
# define PRId64     __PRI64_PREFIX "d"
#endif

#ifndef PRIi8
# define PRIi8      "i"
#endif
#ifndef PRIi8
# define PRIi16     "i"
#endif
#ifndef PRIi8
# define PRIi32     "i"
#endif
#ifndef PRIi8
# define PRIi64     __PRI64_PREFIX "i"
#endif

The second set starts at line 81, and it looks like the #ifndefs were accidentally cut/paste without changing them from PRIi8 to the appropriate type. If this isnt a copy/paste error, it probably should have a comment.

--
Michael Brown


More information about the samba-technical mailing list