[PATCH] s4/dsdb: dsdb_validate_invocation_id() should validate by objectGUID

Stefan (metze) Metzmacher metze at samba.org
Tue Apr 27 00:52:21 MDT 2010

Andrew Bartlett schrieb:
> On Tue, 2010-04-27 at 04:53 +0300, Kamen Mazdrashki wrote:
>> Could you please take a look at following patches:
>> http://gitweb.samba.org/?p=kamenim/samba.git;a=commitdiff;h=c0e57546335376457ca985cea98df6a70a0f875d
>> <http://gitweb.samba.org/?p=kamenim/samba.git;a=commitdiff;h=c0e57546335376457ca985cea98df6a70a0f875d>
>> http://gitweb.samba.org/?p=kamenim/samba.git;a=commitdiff;h=b796836b5eede56c9945d2562b2b9a5c525423c8
>> <http://gitweb.samba.org/?p=kamenim/samba.git;a=commitdiff;h=b796836b5eede56c9945d2562b2b9a5c525423c8>(last
>> 2 commits from:
>> http://gitweb.samba.org/?p=kamenim/samba.git;a=shortlog;h=refs/heads/vampire-test-wip
>> )
> Looking at that branch, we should *not* join as a DC, but as a
> workstation and then upgrade.  Similarly, we should not set dNSHostName
> unless you have seen windows do exactly that call. 
> I know it looks like it fixes it, but metze did a lot of work to make
> this exactly the same as what windows did, packet for packet.  We should
> avoid disturbing that. 

That's correct, but only for the become dc phase, for the plain join I
used the existing libnet_join code, which doesn't match the windows
behavior. I think we should change that based on captures of a w2k8r2
box joining a w2k8r2 domain as a pure domain member.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100427/fb44182d/attachment.pgp>

More information about the samba-technical mailing list