[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Apr 20 08:22:42 MDT 2010


On Tue, Apr 20, 2010 at 10:19:52AM -0400, simo wrote:
> > It would be nice to standardize on one or the other though rather than
> > using a strange mix of both. Should we encourage the use of
> > TALLOC_FREE() over talloc_free() ?
> 
> In my projects I actually use talloc_zfree(), which is similar to
> TALLOC_FREE() but less ugly to see :)
> 
> given in s3 code TALLOC_FREE(0 is absolutely recommended I am ok if we
> want to adopt the same guideline in s4

Given a recent bug I had to fix because I was not aware
SSVAL is a macro (I used val++ in the argument), I have to
agree with Jeremy that macros should be as ugly to read as
possible.

Volker


More information about the samba-technical mailing list