Patches for dealing a bit more cleanly with NTTIME

Matthieu Patou mat+Informatique.Samba at matws.net
Thu Apr 15 04:28:04 MDT 2010


Hi jelmer,

Find attach the new version without any cast + assignement in SamDB.

On 15/04/2010 00:47, Jelmer Vernooij wrote:
> Hi Matthieu,
>
> On Thu, 2010-04-15 at 00:37 +0400, Matthieu Patou wrote:
>    
>> Hello jelmer,
>>
>> This patch is for dealing correctly with NTTIME (64bits) + allowing to
>> print a NTTIME object in a string.
>>      
> You're using PyInt_FromLong((uint64_t)t). That seems wrong because
> sizeof(uint64_t)>  sizeof(long) and t is a time_t. Perhaps you just
> don't want to cast at all?
>
> Cheers,
>
> Jelmer
>    



More information about the samba-technical mailing list