[PATCH] Fix tsocket on solaris

[Jeremy Allison]

On Wed, Apr 07, 2010 at 07:32:07PM +0200, Stefan (metze) Metzmacher wrote:
> Stefan (metze) Metzmacher schrieb:
> > Stefan (metze) Metzmacher schrieb:
> >> Stefan (metze) Metzmacher schrieb:
> >>> Andrew Bartlett schrieb:
> >>>> Solaris seems to error out (EINVAL) if sendto has a socklen parameter
> >>>> that isn't the same as the sizeof() for the relevant socket type.
> >>>>
> >>>> That is, we can't use sizeof(struct sockaddr_storage).
> >>>>
> >>>> This does not show up on the build farm, as we use socket_wrapper, which
> >>>> plays other games.
> >>>>
> >>>> Please find attached and review my proposed patch, which instead tries
> >>>> to keep the length alongside the struct sockaddr at all times. 
> >>> here's my full version of the patch.
> >>>
> >>> It compiles, but I haven't done any real testing.
> >>> make test failed, but I'm not sure the failure is really related.
> > 
> > I think this version should be ok, it fixes a pointer vs. stack variable
> > bug in the recvfrom_handler.
> > 
> > But it still fails with the same error, maybe it's not really related...
> > I'll do more tests tomorrow.
> 
> Ok, this one seems to work better, but I'll do manual tests tomorrow.

Metze - have you pushed this yet ? As I recall it got a good
report from the user.

Jeremy.