[PATCH] s4-drs: Delete RODC filtered attributes from objects

Andrew Bartlett abartlet at samba.org
Mon Apr 12 05:57:12 MDT 2010

On Mon, 2010-04-12 at 13:36 +0300, Anatoliy Atanasov wrote:
> Hi Andrew,
> I scanned all the callbacks that are passed to ldb rename, modify and add functions and I changed them to return referral. Make test is passing. You mentioned that these changes need to be done for other parts of the code too. Can you tell me more about that, so I can change it there too?
> The changes are here, if you are fine with the change i'll push them: http://git.samba.org/?p=anatoliy/anatoliy.git;a=shortlog;h=refs/heads/wip

Also check that the vampire and dcpromo cases still work, but it looks
good to me!

The only comment I have is to reverse the order of the patches, if it's
not too difficult.  That way, you fix up the code to use referrals and
then use them, making it easier on 'git bisect'. 

(I don't hold to the line that every patch must work perfectly if
compiled in the middle of a series - 'git bisect skip' exists for a
reason, but where it's easy I like to at least try). 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20100412/028e5957/attachment.pgp>

More information about the samba-technical mailing list