[PATCH] s4-drs: DsGetReplInfo(), infoType = DS_REPL_INFO_METADATA_2_FOR_OBJ
erick.nogueira.nascimento at gmail.com
Sun Apr 11 17:21:39 MDT 2010
Could you please push these 2 patches into master?
I have one patch finished and finishing another, and I need the
changes introduced by the above on those that I will submit.
Erick Nogueira do Nascimento
Institute of Computing
Campinas State University
On Mar 25, 2010, at 3:47 PM, Erick Nascimento wrote:
> There was an issue in one the last two patches.
> The added line to selftest/knowfail was commented out, here are the
> fixed patches.
> Best Regards,
> Erick Nogueira do Nascimento
> Institute of Computing
> Campinas State University
> 2010/3/24 Erick Nascimento <erick.nogueira.nascimento at gmail.com>:
>> Here is one patch that add a line on selftest/knowfail for the
>> dsgetinfo test cases.
>> The another one just fix the return value for not yet supported
>> Erick Nogueira do Nascimento
>> Institute of Computing
>> Campinas State University
>> On Fri, Mar 19, 2010 at 9:05 PM, Andrew Bartlett
>> <abartlet at samba.org> wrote:
>>> On Fri, 2010-03-19 at 20:36 -0300, Erick Nascimento wrote:
>>>> Here is a patch fixing this. The comments are inside.
>>>> I don't know much about the torture testcases purposes, I tough
>>>> it was
>>>> ok to remove the not yet supported infotypes from being called, but
>>>> maybe I'm wrong.
>>> No, you should instead write up the tests in such a way that they
>>> either not called against Samba4, or (much better) to add them to
>>> known failure file.
>>> Tests should be written to pass against Windows 2008 R2, and then
>>> knownfail updates made so that when run against Samba4, they don't
>>> the overall test.
>>> Andrew Bartlett
>>> Andrew Bartlett http://samba.org/~abartlet/
>>> Authentication Developer, Samba Team http://samba.org
>>> Samba Developer, Cisco Inc.
More information about the samba-technical